Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30386: [Alloy Editor] Custom Buttons #33

Merged
merged 3 commits into from
Apr 5, 2019
Merged

EZP-30386: [Alloy Editor] Custom Buttons #33

merged 3 commits into from
Apr 5, 2019

Conversation

SerheyDolgushev
Copy link
Contributor

Question Answer
JIRA issue EZP-30386
Bug/Improvement yes
New feature yes
Target version master
BC breaks no
Tests pass yes
Doc needed yes

Provides configs for custom buttons in Alloy Editor. Example configuration:

ezrichtext:
    alloy_editor:
        extra_buttons:
            toolbar1: [button1, button2]
            paragraph: [random]

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@SerheyDolgushev SerheyDolgushev changed the title AlloyEditor Extra Buttons EZP-30386: [Alloy Editor] Custom Buttons Apr 1, 2019
@SerheyDolgushev SerheyDolgushev mentioned this pull request Apr 1, 2019
Merged
2 tasks
@dew326 dew326 requested a review from alongosz April 3, 2019 09:09
@micszo micszo self-assigned this Apr 5, 2019
micszo
micszo requested changes Apr 5, 2019
View reviewed changes
src/bundle/DependencyInjection/Configuration.php Outdated
@@ -168,8 +168,16 @@ private function addCustomStylesSection(NodeBuilder $ezRichTextNode)
* ezpublish:
* ezrichtext:
* alloy_editor:
* extra_plugins: [plugin1, plugin2]
* extra_buttons:
* - paragraph: [button1, button2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the hyphens should be removed, it doesn't work with hyphens. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micszo nice catch! Fixed in 00a8a69

@micszo micszo removed their assignment Apr 5, 2019
@lserwatka lserwatka merged commit 6cb9d61 into ezsystems:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SerheyDolgushev @adamwojs @alongosz @micszo @lserwatka